Avoid remove previously added params when adding a suggest to the query #726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we add a suggest to the query (while wanting to keep the query part of the query), the query and all the previoulsy added parameters where removed. Like in the unit test, if we add the query (or the size) then the suggest, the query (or the size) is removed. But if we add the suggest then the query (or the size), the query is still present. So insted of removing all the params, we merge the suggest with the existing parameters.
|
Can you update the changes.txt? |
|
changes.txt updated |
ruflin
added a commit
that referenced
this pull request
Nov 20, 2014
Avoid remove previously added params when adding a suggest to the query
|
Thx. Merged. Interesting that the coverage went down even though a test was added :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we add a suggest to the query (while wanting to keep the query part
of the query), the query and all the previoulsy added parameters where
removed.
Like in the unit test, if we add the query (or the size) then the suggest,
the query (or the size) is removed. But if we add the suggest then the query
(or the size), the query is still present.
So insted of removing all the params, we merge the suggest with the
existing parameters.