Fixed Response::isOk() to work better with bulk update api

[fprochazka]

[Closes #698]

Is such a testcase okey? Or do you want also a functional test?

[coveralls]

Coverage increased (+0.13%) when pulling da1e5b0 on fprochazka:bug/response-isok into c9f41fa on ruflin:master.

[coveralls]

Coverage increased (+0.16%) when pulling cad5ec4 on fprochazka:bug/response-isok into c9f41fa on ruflin:master.

[fprochazka]

@ruflin any thoughts? :)

[ruflin]

The tests are ok and quite extensive, I like that 👍 Functional and integration tests are a big plus as it makes sure, it also works with the specific elasticsearch version. This makes it very easy to detect, in case some (return)parameters change. I you can add 1 or 2 integration tests, I'm more then happy.

[fprochazka]

@ruflin I would love to write those tests, but I don't know when I'll have the time for it. I think it would be beneficial to merge this (as the tests clearly pass) and I'll try to write some new tests as soon as I can :) On the other hand, if the integration tests are a must, I would give it a bit higher priority so this can be merged earlier. It's up to you :)

[ruflin]

I already merged as it doesn't break any of the existing tests. Of course I would still like to make it a higher priority on your side anyways ;-)

Thx for the addition.

[fprochazka]

I'll try to write them soon Kdyby/ElasticSearch#2 :) Thank you for the merge!

[ruflin]

👍