Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the branch alias for master #683

Merged
merged 2 commits into from
Sep 22, 2014
Merged

Fixed the branch alias for master #683

merged 2 commits into from
Sep 22, 2014

Conversation

stof
Copy link
Contributor

@stof stof commented Sep 22, 2014

No description provided.

@ruflin
Copy link
Owner

ruflin commented Sep 22, 2014

@stof Can you update the changes.txt file?

@stof
Copy link
Contributor Author

stof commented Sep 22, 2014

is it really worth it ? this is just something which should have been part of the release process actually (master already contains the 1.3.x codebase before my change, not the 1.2.x one)

@ruflin
Copy link
Owner

ruflin commented Sep 22, 2014

Yes, I think it is worth to mention as you rightly said, that it is not part of the release process yet. Probably this should be added here: http://elastica.io/release/how-to-create-an-elastica-release.html

@stof
Copy link
Contributor Author

stof commented Sep 22, 2014

I updated it

@fprochazka
Copy link
Contributor

@ruflin you know.. if there is going to be every insignificant change in the file, than you're basically recreating commit log and having more noise than useful informations in the changes.txt... changelog is for changes that are relevant if you're updating the lib, like "added method, added feature, bc break, ..." not noise like typo and release process details.

Just saying.

ruflin added a commit that referenced this pull request Sep 22, 2014
Fixed the branch alias for master
@ruflin ruflin merged commit a775593 into ruflin:master Sep 22, 2014
@stof stof deleted the patch-1 branch September 22, 2014 15:22
@ruflin
Copy link
Owner

ruflin commented Sep 22, 2014

@fprochazka My view on this:

  • Every pull request should be related to an issue. Every issue is hopefully relevant.
  • Every pull request consists of several commits.
  • Every issue / pull request should have a self explanatory title
  • The changelog should be generated of the issues with the titles (automated).

We are definitively missing the last points which would make to change the changes.txt file manually obsolete. That is where the project should be heading.

@Tobion
Copy link
Collaborator

Tobion commented Oct 8, 2014

So if there is a PR to fix typos. This will be part of the changelog. I agree this is too much noise.

@ruflin
Copy link
Owner

ruflin commented Oct 8, 2014

I fully agree on documentation typos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants