Stop ScanAndScrollTest from failing spuriously #635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScanAndScrollTest->testQuerySizeOverride used the rewind method on ScanAndScroll which executes a scroll query on Elasticsearch without making sure that the index is fully allocated. Apparently, this can cause Elasticsearch to throw back an error. We work around this by adding a refresh before the rewind.
|
I didn't make an issue for this one. Do you want one? |
|
No, not necessary. Lets wait for the result :-) |
|
Much better. |
ruflin
added a commit
that referenced
this pull request
Jun 13, 2014
Stop ScanAndScrollTest from failing spuriously
|
Merged. Thx. |
|
@nik9000 Side note here: All your changes are in the newest 1.2.1.0 release https://github.com/ruflin/Elastica/releases/tag/v1.2.1.0 |
|
Thanks! On Sun, Jun 15, 2014 at 4:33 AM, Nicolas Ruflin [email protected]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ScanAndScrollTest->testQuerySizeOverride used the rewind method on
ScanAndScroll which executes a scroll query on Elasticsearch without making
sure that the index is fully allocated. Apparently, this can cause
Elasticsearch to throw back an error. We work around this by adding a
refresh before the rewind.