toString updated to consider doc_as_upsert if sent an array source #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s UpdateDocuments setDocument does)
|
Can you update the changes.txt and add a small test for this change? |
ruflin
added a commit
that referenced
this pull request
Jun 2, 2014
toString updated to consider doc_as_upsert if sent an array source
|
Merged. Thx. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setDocument in Bulk/Action/UpdateDocument does set doc_as_upsert as expected, but the Bulk/Action toString method condition for source as an array did not include include it into the json sent to elastic search if present.