Aggragations/Filter - fix for es1.2 when no sub aggregations

[krzaczek]

Hi,

Small fix for Elastica/Aggregation/Filter.php. There is a bug when no subaggregation is set ... see "by_category_feature"

"aggs": {
        "global": {
            "global": {},
            "aggs": {
                "by_category_feature": {
                    "filter": {
                        "match_all": {}
                    },
                  "aggs": []
                }
            }
        }
    }

This will cause an error in elasticsearch because "aggs" cannot be [] ... it should be {} .. or we can just omit the aggs when there are none present.

"aggs": {
        "global": {
            "global": {},
            "aggs": {
                "by_category_feature": {
                    "filter": {
                        "match_all": {}
                    }
                }
            }
        }
    }

This will work fine :)

[coveralls]

Coverage increased (+0.02%) when pulling e0f6271 on krzaczek:fix-aggs-filter into 58b0928 on ruflin:master.

[krzaczek]

Sorry for the mess .. wil squash this to one commit .. but just don't have the time right now ...

[krzaczek]

Ok squashed

[ruflin]

Can you update the changes.txt file and add a small test to make sure, it works as expected also in the future?

[krzaczek]

sure will do on monday

pawel (at) mobile

On 24 maj 2014, at 23:45, Nicolas Ruflin [email protected] wrote:

Can you update the changes.txt file and add a small test to make sure, it works as expected also in the future?

—
Reply to this email directly or view it on GitHub.

[krzaczek]

Should work now ....

[coveralls]

Coverage increased (+0.1%) when pulling 09a223c on krzaczek:fix-aggs-filter into 83fd5c4 on ruflin:master.

[ruflin]

Merged. Thx.