JSON Compat Library #614
Merged
JSON Compat Library #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $args = func_get_args(); | ||
|
|
||
| // default to decoding into an assoc array | ||
| if (sizeof($args) < 2) |
There was a problem hiding this comment.
Use brackets please (like line 37).
|
I like this 👍 |
- Removes need for global constant definitions - Allows easier handling of JSON parse errors
|
Yeah, Travis sometimes does that. Not sure why :-( I will restart the build. I also like this, especially because everything still seems to work :-) |
|
Almost all builds went green. I merged it. Thx. Will be part of the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
Elastica\JSONclass which provides wrappers forjson_encodeandjson_decode.parse(json_decode)stringify(json_encode)"JSON_ELASTICSEARCH"to be passed as$optionsto use flag settings identified for ES compatability (alternate solution to Introduce ELASTICA_JSON_UNESCAPED_UNICODE ELASTICA_JSON_UNESCAPED_SLASHES #613)Other
If you're happy with this approach, I'll add some additional tests; just didn't want to spend time writing them if you opt not to go this route. Cheers!