Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Support for setting analyzer on fuzzy like this query and params cannot be set #611

Merged
merged 3 commits into from
May 10, 2014

Conversation

PurpleHexagon
Copy link

In documentation of elasticsearch you can set an analyzer when using fuzzy like this query

http://www.elasticsearch.org/guide/en/elasticsearch/reference/current/query-dsl-flt-query.html

this is not supported in elastica.

Also fix for setParam method data to be included in $args array

@ruflin
Copy link
Owner

ruflin commented May 8, 2014

Can you update the changes.txt file?

@PurpleHexagon
Copy link
Author

  • Updated changes.txt
  • Added additional test to ensure params overrides params of object as per comment line 90 of Elastica\Params
  • updated Elastica\Query\FuzzyLikeThis toArray method to use array_merge so test passes

@ruflin
Copy link
Owner

ruflin commented May 8, 2014

Chan you add also an integration test to make sure it works with the current ES version?

BTW: That the builds fail is not because of your code, but because of a problem with phpunit 4.0.* which makes the builds really slow. Not sure why yet.

@PurpleHexagon
Copy link
Author

No problem, I will add these in the morning :)

…st version of elasticseach tested with 1.1.1
@PurpleHexagon
Copy link
Author

I've added test to test that analyzers work with fuzzyLikeThis Query

ruflin added a commit that referenced this pull request May 10, 2014
No Support for setting analyzer on fuzzy like this query and params cannot be set
@ruflin ruflin merged commit 93b96f7 into ruflin:master May 10, 2014
@ruflin
Copy link
Owner

ruflin commented May 11, 2014

Merged. Thx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants