Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cardinality aggregation #581

Merged
merged 3 commits into from
Apr 10, 2014
Merged

Cardinality aggregation #581

merged 3 commits into from
Apr 10, 2014

Conversation

attilabukor
Copy link
Contributor

Added cardinality aggregation

@ruflin
Copy link
Owner

ruflin commented Apr 9, 2014

Can you also update the changes.txt file?

Looks like one of the tests is also failing because of the Cardinality:

1) Elastica\Test\Aggregation\CardinalityTest::testCardinalityAggregation
Undefined variable: result
/home/travis/build/ruflin/Elastica/test/lib/Elastica/Test/Aggregation/CardinalityTest.php:35

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 6e64b42 on r1pp3rj4ck:cardinality into b610d4f on ruflin:master.

ruflin added a commit that referenced this pull request Apr 10, 2014
@ruflin
Merge pull request #581 from r1pp3rj4ck/cardinality
cb57ddd 
Cardinality aggregation
@ruflin ruflin merged commit cb57ddd into ruflin:master Apr 10, 2014
@ruflin
Copy link
Owner

ruflin commented Apr 10, 2014

Thx. Merged.

@attilabukor attilabukor deleted the cardinality branch April 19, 2014 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@attilabukor @ruflin @coveralls