Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terms filter lookup should accept routing and cache params #579

Closed
MrHash opened this issue Apr 5, 2014 · 1 comment
Closed

Terms filter lookup should accept routing and cache params #579

MrHash opened this issue Apr 5, 2014 · 1 comment

Comments

@MrHash
Copy link
Contributor

MrHash commented Apr 5, 2014

As described here: http://www.elasticsearch.org/guide/en/elasticsearch/reference/current/query-dsl-terms-filter.html#_terms_lookup_mechanism

Should the argument list be extended after $index?
https://github.com/ruflin/Elastica/blob/master/lib/Elastica/Filter/Terms.php#L73

@ruflin
Copy link
Owner

ruflin commented Apr 5, 2014

It looks like the first 4 are mandatory, the additional ones are optional one. So instead of extending, I would suggest to replace $index with $options = array(). And to make it BW compatible, in case it isn't an array, $index is picked. Like this also params can be added in the future without having to change the function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants