Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FunctionScore: boost_factor function not supported #491

Closed
Xylakant opened this issue Oct 31, 2013 · 3 comments
Closed

FunctionScore: boost_factor function not supported #491

Xylakant opened this issue Oct 31, 2013 · 3 comments

Comments

@Xylakant
Copy link

The boost_factor function is not supported since the signature for addFunction() expects the function_parameters to be an array, but the boost_factor accepts a single float value.

see https://github.com/ruflin/Elastica/blob/master/lib/Elastica/Query/FunctionScore.php#L61 and http://www.elasticsearch.org/guide/en/elasticsearch/reference/current/query-dsl-function-score-query.html#_boost_factor

@ruflin
Copy link
Owner

ruflin commented Nov 2, 2013

Ok, I see. Looks like we have to do some refactoring of FunctionScore and especially add some tests.

@leabaertschi
Copy link
Contributor

Did you already do something about that? If not I could have a look because I need this quite urgently...

@ruflin
Copy link
Owner

ruflin commented Dec 2, 2013

I will close this one as the pull request is merged and I think it solves this problem.

@ruflin ruflin closed this as completed Dec 2, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants