Bug with PHP 7.2

[kukulich]

Warning: count(): Parameter must be an array or an object that implements Countable in https://github.com/ruflin/Elastica/blob/master/lib/Elastica/Query.php#L333

[p365labs]

can you show us the code that generate this error ?

[kukulich]

The bug is here: https://github.com/ruflin/Elastica/blob/master/lib/Elastica/Query.php#L425

Elastica\Query\AbstractQuery doesn't implement Countable.

[p365labs]

I confirm that @kukulich is right.
PHP 7.2 change a bit count() function (search for Countable).

count() now raises a warning when an invalid parameter is passed. Only arrays and objects implementing the Countable interface should be passed.

I think could it be useful having a PR ready to be merged when PHP 7.2 will be released, at the moment PHP 7.2 is a Release Candidate 2, so not ready for production use.

[ruflin]

@kukulich Thanks for reporting. Always good to have people testing early with future versions.

I'm ok with getting a fix in before GA is out as I assume it will not be a breaking change?

@p365labs Thanks for starting the work on this.

[p365labs]

hi all! I think we can close this one as this PR #1378 solves the problem :)