Skip to content

Commit 3660612

Browse files
committed
Modify _log to provide more context
1 parent f3cde26 commit 3660612

File tree

1 file changed

+26
-12
lines changed

1 file changed

+26
-12
lines changed

lib/Elastica/Client.php

+26-12
Original file line numberDiff line numberDiff line change
@@ -621,17 +621,15 @@ public function bulk(array $params)
621621
public function request($path, $method = Request::GET, $data = array(), array $query = array())
622622
{
623623
$connection = $this->getConnection();
624+
$request = null;
625+
$response = null;
626+
624627
try {
625628
$request = new Request($path, $method, $data, $query, $connection);
626-
627-
$this->_log($request);
628-
629629
$response = $request->send();
630630

631631
$this->_lastRequest = $request;
632632
$this->_lastResponse = $response;
633-
634-
return $response;
635633
} catch (ConnectionException $e) {
636634
$this->_connectionPool->onFail($connection, $e, $this);
637635

@@ -642,6 +640,10 @@ public function request($path, $method = Request::GET, $data = array(), array $q
642640

643641
return $this->request($path, $method, $data, $query);
644642
}
643+
644+
$this->_log($request, $response);
645+
646+
return $response;
645647
}
646648

647649
/**
@@ -673,29 +675,41 @@ public function refreshAll()
673675
/**
674676
* Log a request if the logger is present.
675677
*
676-
* @param \Elastica\Request $request
677-
*
678-
* @throws Exception\RuntimeException
678+
* @param Request $request
679+
* @param Response $response
679680
*/
680-
protected function _log(Request $request)
681+
protected function _log(Request $request, Response $response = null)
681682
{
682683
if (!$this->_logger) {
683684
return;
684685
}
685686

686-
$this->_logger->debug('Elastica Request', $request->toArray());
687+
$this->_logger->debug('Elastica Request', [
688+
'request' => $request->toArray(),
689+
'response' => $response ? $response->getData() : null
690+
]);
687691
}
688692

689693
/**
690-
* @return \Elastica\Request
694+
* Replace the existing logger.
695+
*
696+
* @param LoggerInterface $logger
697+
*/
698+
public function setLogger(LoggerInterface $logger)
699+
{
700+
$this->_logger = $logger;
701+
}
702+
703+
/**
704+
* @return Request
691705
*/
692706
public function getLastRequest()
693707
{
694708
return $this->_lastRequest;
695709
}
696710

697711
/**
698-
* @return \Elastica\Response
712+
* @return Response
699713
*/
700714
public function getLastResponse()
701715
{

0 commit comments

Comments
 (0)