Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow DomainModules that can only encode or only decode #14

Open
bdvllrs opened this issue Mar 21, 2024 · 1 comment
Open

Allow DomainModules that can only encode or only decode #14

bdvllrs opened this issue Mar 21, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@bdvllrs
Copy link
Collaborator

bdvllrs commented Mar 21, 2024

Now every DomainModule has to encode and decode representations.

We should have a way to tell to the modules whether they are encoders, decoders or both.

@bdvllrs bdvllrs added the enhancement New feature or request label Mar 21, 2024
@bdvllrs
Copy link
Collaborator Author

bdvllrs commented Mar 29, 2024

This is still an open question to how we will implement this.

To me, the easiest way to define a decoder-only or encoder-only domain would be to not implement the encode or decode of the domain (default implementation raises NoImplementedError).

Then the encode_domains would try to encode and skip if NoImplementedError is raised.

The question is how do we handle data. We certainly want to do translations toward decoder-only domains so raw representations should be available, but then we can't compare with the GW representation because this is not available. Do we need a special case for those where the error happens after decoding of the domain?

In this case it also raises the question of how data is given to the model. For now everything is given at once because everything can be inputs or outputs. We might need to separate them input "input" domains and "target" domains.
An alternative would be to infer this in the data based on the domain (if it's decoder only, data is target).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant