chore: generateTransformationMessage is its own concurrent step #5449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sidddddarth
changed the title
Sidddddarth
force-pushed
the
chore.newProcessorStep_generateTransformationMessage
branch
from
727f6dc to
eb3998c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5449 +/- ##
==========================================
+ Coverage 74.99% 75.01% +0.02%
==========================================
Files 460 460
Lines 63532 63548 +16
==========================================
+ Hits 47644 47673 +29
+ Misses 13227 13218 -9
+ Partials 2661 2657 -4 ☔ View full report in Codecov by Sentry. |
ktgowtham
approved these changes
Jan 28, 2025
processor/processor.go
Outdated
| hasMore: false, | ||
| rsourcesStats: rsourcesStats, | ||
| }) | ||
| transMessage, err = proc.generateTransformationMessage(proc.processJobsForDest( |
There was a problem hiding this comment.
not related to this PR. but there's a possibility of duplicate persistence of jobs in events schema and archival?
mihir20
requested changes
Jan 30, 2025
processor/processor.go
Outdated
| @@ -1734,7 +1734,7 @@ func (proc *Handle) processJobsForDest(partition string, subJobs subJob) (*trans | |||
| for _, batchEvent := range jobList { | |||
| var eventParams types.EventParams | |||
| if err := jsonfast.Unmarshal(batchEvent.Parameters, &eventParams); err != nil { | |||
| return nil, err | |||
| panic(err) | |||
There was a problem hiding this comment.
lets return error from here, we can handle error at 1 place only in worker.go
mihir20
reviewed
Feb 7, 2025
It might lead to some complexity in that it'll involve extra handling to choose the channel to put things in based on the flag. And eventually some more at shutdown too. Imo we can go ahead without a flag because the only concern could be memory usage - but that's blocked at the |
Sidddddarth
deleted the
chore.newProcessorStep_generateTransformationMessage
branch
This was referenced Feb 18, 2025
Closed
Merged
satishrudderstack
pushed a commit
that referenced
this pull request
Feb 19, 2025
🤖 I have created a release *beep* *boop* --- ## [1.43.0](v1.42.0...v1.43.0) (2025-02-18) ### Features * add a new implementation of schema with ttl ([#5462](#5462)) ([c708863](c708863)) * implement snowpipe destination config validation ([#5472](#5472)) ([a3810fc](a3810fc)) * introduce router transformer metrics for cost attribution ([#5511](#5511)) ([a8b3a00](a8b3a00)) * introduce transformer metrics for cost attribution ([#5505](#5505)) ([90d1f24](90d1f24)) * sync latency metrics api ([#5500](#5500)) ([b35a657](b35a657)) * updated validation check for microsoftClickId in bingads_offline_conversions async destination ([#5514](#5514)) ([6468c42](6468c42)) ### Bug Fixes * async framework destination live events ([#5480](#5480)) ([4938a25](4938a25)) * databricks columns to add becomes empty after filtering ([#5494](#5494)) ([4854220](4854220)) * deltalake syncs failing for columns with unhandled data type ([#5467](#5467)) ([28d6072](28d6072)) * security vulnerabilities ([#5481](#5481)) ([d89b8cc](d89b8cc)) * snowpipe streaming error enrichment for failed events ([#5479](#5479)) ([737a42a](737a42a)) * warehouse transformations SourceDefinitionType as empty ([#5510](#5510)) ([15faf6b](15faf6b)) ### Miscellaneous * **deps:** bump google.golang.org/protobuf from 1.36.4 to 1.36.5 in the go-deps group ([#5489](#5489)) ([e0b64f8](e0b64f8)) * **deps:** bump the go-deps group across 1 directory with 14 updates ([#5478](#5478)) ([1ab22b0](1ab22b0)) * fix gateway metrics ([#5483](#5483)) ([4938a25](4938a25)) * generateTransformationMessage is its own concurrent step ([#5449](#5449)) ([734e759](734e759)) * integrate build-scan-push-action to scan docker images ([#5464](#5464)) ([e9579b8](e9579b8)) * make cslb configurable ([#5451](#5451)) ([4938a25](4938a25)) * migration to drop unused wh_schema_versions table ([#5469](#5469)) ([28d6072](28d6072)) * sanitise sample event payload and sample response before inserting in reports table ([#5493](#5493)) ([9ec7552](9ec7552)) * sync release v1.42.1 to main branch ([#5477](#5477)) ([ad74333](ad74333)) * track event name post user transformation for reporting ([#5501](#5501)) ([7fcdc47](7fcdc47)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
generateTransformationMessage is its own concurrent step.
Includes:
Linear Ticket
Resolves PIPE-1719
Security