Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: ensure health endpoint backwards compatibility #4614

Merged
merged 2 commits into from
Apr 24, 2024
Merged

chore: ensure health endpoint backwards compatibility #4614

merged 2 commits into from
Apr 24, 2024

Conversation

lvrach
Copy link
Member

@lvrach lvrach commented Apr 24, 2024 •
edited
Loading

Description

This PR introduced a breaking change for the health endpoint https://github.com/rudderlabs/rudder-server/pull/4584/files#diff-0f1d2976054440336a576d47a44a37b80cdf6701dd9113012bce0e3c425819b7R168

Thus hard-coding the routingEvents to always true, since we remove recovery on rudder-server.

Linear Ticket

https://linear.app/rudderstack/issue/PIPE-1033/health-endpoint-backwards-compatibility

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Apr 24, 2024

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@lvrach lvrach marked this pull request as ready for review April 24, 2024 09:52
mihir20
mihir20 reviewed Apr 24, 2024
View reviewed changes
app/app.go Outdated
@@ -165,7 +165,7 @@ func getHealthVal(jobsDB jobsdb.JobsDB) (bool, string) {

appTypeStr := strings.ToUpper(config.GetString("APP_TYPE", EMBEDDED))
return healthy, fmt.Sprintf(
`{"appType":"%s","server":"UP","db":"%s","acceptingEvents":"TRUE","mode":"%s",`+
`{"appType":"%s","server":"UP","db":"%s","acceptingEvents":"TRUE","routingEvents":"TRUE","mode":"%s",`+
Copy link
Contributor

@mihir20 mihir20 Apr 24, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we wanted to remove mode in place we accidentally removed routingEvents

Suggested change
`{"appType":"%s","server":"UP","db":"%s","acceptingEvents":"TRUE","routingEvents":"TRUE","mode":"%s",`+
`{"appType":"%s","server":"UP","db":"%s","acceptingEvents":"TRUE","routingEvents":"%s",`+

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

@lvrach lvrach requested a review from mihir20 April 24, 2024 10:05
mihir20
mihir20 approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@mihir20 mihir20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lvrach lvrach enabled auto-merge (squash) April 24, 2024 10:12
@lvrach lvrach merged commit 87a2dfa into master Apr 24, 2024
50 checks passed
@lvrach lvrach deleted the chore.health branch April 24, 2024 10:31
This was referenced Apr 24, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sidddddarth Sidddddarth Sidddddarth approved these changes

@achettyiitr achettyiitr achettyiitr approved these changes

@mihir20 mihir20 mihir20 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lvrach @mihir20 @achettyiitr @Sidddddarth