-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add sourceCategory label to event_delivery_time metric #4569
chore: add sourceCategory label to event_delivery_time metric #4569
Conversation
Important Auto Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4569 +/- ##
==========================================
- Coverage 74.26% 74.25% -0.02%
==========================================
Files 411 411
Lines 48298 48301 +3
==========================================
- Hits 35869 35864 -5
- Misses 10082 10086 +4
- Partials 2347 2351 +4 ☔ View full report in Codecov by Sentry. |
For event-stream instead of sending an empty value, should we send some appropriate value like we are doing for reporting? |
@@ -166,6 +166,7 @@ func (w *worker) workLoop() { | |||
UserID: userID, | |||
JobID: job.JobID, | |||
SourceID: parameters.SourceID, | |||
SourceCategory: parameters.SourceCategory, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are using similar logic to populate sourceCategory for reporting
We are thinking of updating the |
Description
sourceCategory
label onevent_delivery_time
metric so that we can query usingsourceCategory
sourceCategory="warehouse"
for rETL,sourceCategory=""
for eventStream andsourceCategory="webhook"
for customerio sourcecompletes OBS-453
Linear Ticket
https://linear.app/rudderstack/issue/OBS-453/add-sourcecategory-label-to-event-delivery-time-metric
Security