Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add sourceCategory label to event_delivery_time metric #4569

Merged

Conversation

satishrudderstack
Copy link
Contributor

@satishrudderstack satishrudderstack commented Apr 10, 2024

Description

  • As part of delays project, we want to show end-to-end delay for event stream cloud destinations. We are adding sourceCategory label on event_delivery_time metric so that we can query using sourceCategory
  • Tested by deploying a dataplane on dev cluster. We are getting sourceCategory="warehouse" for rETL, sourceCategory="" for eventStream and sourceCategory="webhook" for customerio source
    • Attaching part of result from /metrics from processor pod
Screenshot 2024-04-12 at 2 08 49 PM

completes OBS-453

Linear Ticket

https://linear.app/rudderstack/issue/OBS-453/add-sourcecategory-label-to-event-delivery-time-metric

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

Copy link
Contributor

coderabbitai bot commented Apr 10, 2024

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@satishrudderstack satishrudderstack marked this pull request as draft April 10, 2024 08:04
Copy link

codecov bot commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.25%. Comparing base (c41ae57) to head (7deb2f9).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4569      +/-   ##
==========================================
- Coverage   74.26%   74.25%   -0.02%     
==========================================
  Files         411      411              
  Lines       48298    48301       +3     
==========================================
- Hits        35869    35864       -5     
- Misses      10082    10086       +4     
- Partials     2347     2351       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@satishrudderstack satishrudderstack marked this pull request as ready for review April 12, 2024 08:41
@achettyiitr
Copy link
Member

For event-stream instead of sending an empty value, should we send some appropriate value like we are doing for reporting?

@@ -166,6 +166,7 @@ func (w *worker) workLoop() {
UserID: userID,
JobID: job.JobID,
SourceID: parameters.SourceID,
SourceCategory: parameters.SourceCategory,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are using similar logic to populate sourceCategory for reporting

@satishrudderstack
Copy link
Contributor Author

For event-stream instead of sending an empty value, should we send some appropriate value like we are doing for reporting?

We are thinking of updating the category column in source_definitions table in config-backend db instead of adding default values at multiple places. For eventStream sources, the category column is empty currently

@satishrudderstack satishrudderstack merged commit 1a5da41 into master Apr 15, 2024
52 checks passed
@satishrudderstack satishrudderstack deleted the chore.add-source-category-to-event-delivery-time branch April 15, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants