chore: log config init errors using exposed methods #4541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Auto Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
1 task
achettyiitr
approved these changes
Apr 4, 2024
Comment on lines
+103
to
+114
| path, err := config.Default.ConfigFileUsed() | ||
| if err != nil { | ||
| r.logger.Warnf("Config: Failed to parse config file from path %q, using default values: %v", path, err) | ||
| } else { | ||
| r.logger.Infof("Config: Using config file: %s", path) | ||
| } | ||
|
|
||
| if err := config.Default.DotEnvLoaded(); err != nil { | ||
| r.logger.Infof("Config: No .env file loaded: %v", err) | ||
| } else { | ||
| r.logger.Infof("Config: Loaded .env file") | ||
| } |
There was a problem hiding this comment.
Suggested change
| path, err := config.Default.ConfigFileUsed() | |
| if err != nil { | |
| r.logger.Warnf("Config: Failed to parse config file from path %q, using default values: %v", path, err) | |
| } else { | |
| r.logger.Infof("Config: Using config file: %s", path) | |
| } | |
| if err := config.Default.DotEnvLoaded(); err != nil { | |
| r.logger.Infof("Config: No .env file loaded: %v", err) | |
| } else { | |
| r.logger.Infof("Config: Loaded .env file") | |
| } | |
| path, err := config.Default.ConfigFileUsed() | |
| if err != nil { | |
| r.logger.Warnn("Config: Failed to parse config file, using default values", | |
| logger.NewStringField("path", path), | |
| obskit.Error(err), | |
| ) | |
| } else { | |
| r.logger.Infon("Config: Using config file", logger.NewStringField("path", path)) | |
| } | |
| if err := config.Default.DotEnvLoaded(); err != nil { | |
| r.logger.Infon("Config: No .env file loaded", obskit.Error(err)) | |
| } else { | |
| r.logger.Infon("Config: Loaded .env file") | |
| } |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4541 +/- ##
==========================================
- Coverage 74.24% 74.22% -0.03%
==========================================
Files 413 413
Lines 48371 48380 +9
==========================================
- Hits 35915 35909 -6
- Misses 10111 10122 +11
- Partials 2345 2349 +4 ☔ View full report in Codecov by Sentry. |
cisse21
approved these changes
Apr 12, 2024
This was referenced Apr 23, 2024
This was referenced Apr 23, 2024
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WARN: To be merge after rudder-go-kit change is merged and released.
Description
Related and depended on rudderlabs/rudder-go-kit#406
Config init error will no longer be logged but the library, rather two methods are exposed so they can be handled downstream.
This is how the output looks like now:
No errors:
With errors:
vs before:
Linear Ticket
https://linear.app/rudderstack/issue/PIPE-956/rudder-go-kit-config-init-error-logs
resolves PIPE-956
Security