chore: add env to enable throttlerV2 #4313
Conversation
|
Important Auto Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
| config: adaptiveConf, | ||
| limitFactorMeasurement: limitFactorMeasurement, | ||
| var at Throttler = &noOpThrottler{} | ||
| if f.config.GetBool("Router.throttlerV2.enabled", true) { |
There was a problem hiding this comment.
By default, should this be false?
There was a problem hiding this comment.
I made it true by default because the actual idea is to run both adaptive and static together. We are only going to set it as false if adaptive causes an issue after the release
| @@ -52,6 +52,25 @@ func TestFactory(t *testing.T) { | |||
| }, 2*time.Second, 100*time.Millisecond, "limit: %d, expectedLimit: %d", ta.getLimit(), maxLimit*5/10) | |||
| }) | |||
| }) | |||
|
|
|||
| t.Run("when throttlerV2 is false", func(t *testing.T) { | |||
| config := config.New() | |||
There was a problem hiding this comment.
[optional]: Variable 'config' collides with imported package name
| config := config.New() | |
| conf := config.New() |
Description
add env to enable throttlerV2
Security