-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: server panics during shutdown with reporting metrics: failed to store jobs: context canceled #4228
Conversation
…store jobs: context canceled
Important Auto Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ? TipsChat with CodeRabbit Bot (
|
…led to store jobs: context canceled
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/v1.18.x #4228 +/- ##
===================================================
- Coverage 74.23% 73.91% -0.32%
===================================================
Files 397 388 -9
Lines 58337 54800 -3537
===================================================
- Hits 43305 40505 -2800
+ Misses 12704 11979 -725
+ Partials 2328 2316 -12 ☔ View full report in Codecov by Sentry. |
Description
Processor, router & batchrouter cannot gracefully shutdown while their loops are working, since any error during the loop will lead to a panic. Thus all reporters'
Report
method need to honour a different context, that of the caller, and not the app's lifecycle context.Report
methodSecurity