Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove events schemas v1 #3923

Merged
merged 1 commit into from
Dec 7, 2023
Merged

chore: remove events schemas v1 #3923

merged 1 commit into from
Dec 7, 2023

Conversation

atzoum
Copy link
Contributor

@atzoum atzoum commented Sep 28, 2023

Description

Removing support for the previous version of event schemas

Linear Ticket

Resolves PIPE-427

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (57f1af1) 72.48% compared to head (648474f) 73.63%.
Report is 1 commits behind head on master.

❗ Current head 648474f differs from pull request most recent head 51c2af1. Consider uploading reports for the commit 51c2af1 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3923      +/-   ##
==========================================
+ Coverage   72.48%   73.63%   +1.14%     
==========================================
  Files         389      374      -15     
  Lines       56165    53883    -2282     
==========================================
- Hits        40713    39678    -1035     
+ Misses      13081    11923    -1158     
+ Partials     2371     2282      -89     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atzoum atzoum force-pushed the chore.dropEventSchemasV1 branch 3 times, most recently from e79a7fe to 562e83e Compare September 28, 2023 11:39
@atzoum atzoum force-pushed the chore.dropEventSchemasV1 branch from 562e83e to 7ecb32b Compare October 13, 2023 15:27
Copy link

github-actions bot commented Nov 4, 2023

This PR is considered to be stale. It has been open 20 days with no further activity thus it is going to be closed in 5 days. To avoid such a case please consider removing the stale label manually or add a comment to the PR.

@github-actions github-actions bot added the Stale label Nov 4, 2023
@atzoum atzoum removed the Stale label Nov 6, 2023
@atzoum atzoum force-pushed the chore.dropEventSchemasV1 branch from 7ecb32b to 4086f72 Compare November 17, 2023 13:15
@atzoum atzoum force-pushed the chore.dropEventSchemasV1 branch from 4086f72 to 9c23b13 Compare November 17, 2023 13:23
@atzoum atzoum marked this pull request as draft November 17, 2023 13:24
@atzoum atzoum changed the title [WIP] chore: remove events schemas v1 chore: remove events schemas v1 Nov 17, 2023
@atzoum atzoum force-pushed the chore.dropEventSchemasV1 branch 2 times, most recently from da449a9 to 648474f Compare November 21, 2023 10:30
@atzoum atzoum force-pushed the chore.dropEventSchemasV1 branch from 648474f to b7a8db1 Compare December 6, 2023 16:13
Copy link
Contributor

coderabbitai bot commented Dec 6, 2023

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

@atzoum atzoum marked this pull request as ready for review December 6, 2023 16:14
@atzoum atzoum merged commit 14466dc into master Dec 7, 2023
40 checks passed
@atzoum atzoum deleted the chore.dropEventSchemasV1 branch December 7, 2023 06:39
This was referenced Jan 15, 2024
This was referenced Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants