Skip to content

Commit 1422c5e

Browse files
committed
add throttler factory to tests
1 parent 9154c43 commit 1422c5e

File tree

3 files changed

+7
-5
lines changed

3 files changed

+7
-5
lines changed

app/cluster/integration_test.go

+3
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ import (
3434
"github.com/rudderlabs/rudder-server/router"
3535
"github.com/rudderlabs/rudder-server/router/batchrouter"
3636
routermanager "github.com/rudderlabs/rudder-server/router/manager"
37+
"github.com/rudderlabs/rudder-server/router/throttler"
3738
destinationdebugger "github.com/rudderlabs/rudder-server/services/debugger/destination"
3839
transformationdebugger "github.com/rudderlabs/rudder-server/services/debugger/transformation"
3940
"github.com/rudderlabs/rudder-server/services/fileuploader"
@@ -217,6 +218,7 @@ func TestDynamicClusterManager(t *testing.T) {
217218
processor.BackendConfig = mockBackendConfig
218219
processor.Transformer = mockTransformer
219220
mockBackendConfig.EXPECT().WaitForConfig(gomock.Any()).Times(1)
221+
throttlerFactory, _ := throttler.NewFactory(config.New(), nil)
220222

221223
rtFactory := &router.Factory{
222224
Logger: logger.NOP,
@@ -226,6 +228,7 @@ func TestDynamicClusterManager(t *testing.T) {
226228
ProcErrorDB: readErrDB,
227229
TransientSources: transientsource.NewEmptyService(),
228230
RsourcesService: mockRsourcesService,
231+
ThrottlerFactory: throttlerFactory,
229232
}
230233
brtFactory := &batchrouter.Factory{
231234
Reporting: &reporting.NOOP{},

router/handle.go

+1-5
Original file line numberDiff line numberDiff line change
@@ -296,11 +296,7 @@ func (rt *Handle) commitStatusList(workerJobStatuses *[]workerJobStatus) {
296296
if err != nil {
297297
errorCode = 200
298298
}
299-
if rt.throttlerFactory != nil {
300-
rt.throttlerFactory.Get(rt.destType, parameters.DestinationID).ResponseCodeReceived(errorCode) // send response code to throttler
301-
} else {
302-
rt.logger.Debugf("[%v Router] :: ThrottlerFactory is nil. Not sending response code to throttler", rt.destType)
303-
}
299+
rt.throttlerFactory.Get(rt.destType, parameters.DestinationID).ResponseCodeReceived(errorCode) // send response code to throttler
304300
// Update metrics maps
305301
// REPORTING - ROUTER - START
306302
workspaceID := workerJobStatus.status.WorkspaceId

router/manager/manager_test.go

+3
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ import (
2828
mocksBackendConfig "github.com/rudderlabs/rudder-server/mocks/backend-config"
2929
"github.com/rudderlabs/rudder-server/router"
3030
"github.com/rudderlabs/rudder-server/router/batchrouter"
31+
"github.com/rudderlabs/rudder-server/router/throttler"
3132
"github.com/rudderlabs/rudder-server/services/rsources"
3233
"github.com/rudderlabs/rudder-server/services/transientsource"
3334
"github.com/rudderlabs/rudder-server/utils/pubsub"
@@ -193,6 +194,7 @@ func TestRouterManager(t *testing.T) {
193194
mockRtDB := &mockJobsDB{JobsDB: rtDB}
194195
brtDB := jobsdb.NewForReadWrite("batch_rt")
195196
errDB := jobsdb.NewForReadWrite("proc_error")
197+
throttlerFactory, _ := throttler.NewFactory(config.New(), nil)
196198
defer rtDB.Close()
197199
defer brtDB.Close()
198200
defer errDB.Close()
@@ -204,6 +206,7 @@ func TestRouterManager(t *testing.T) {
204206
ProcErrorDB: errDB,
205207
TransientSources: transientsource.NewEmptyService(),
206208
RsourcesService: mockRsourcesService,
209+
ThrottlerFactory: throttlerFactory,
207210
}
208211
brtFactory := &batchrouter.Factory{
209212
Reporting: &reporting.NOOP{},

0 commit comments

Comments
 (0)