From 83a3d0baf7a793451087a27847890ea239c0ebfc Mon Sep 17 00:00:00 2001 From: Laurent Arnoud Date: Sun, 13 Nov 2016 00:05:15 +0100 Subject: [PATCH 1/2] Fix download count to avoid ramdom fail on search_test ref c052833efadd62d855333fd7e2028d4e8b58f53c see https://github.com/spk/rubygems.org/blob/c346b910db404bad1ff209266e4ebd740a5a22b0/app/models/concerns/rubygem_searchable.rb#L138 --- test/integration/search_test.rb | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/test/integration/search_test.rb b/test/integration/search_test.rb index 0e656f25091..7bf7591bfc7 100644 --- a/test/integration/search_test.rb +++ b/test/integration/search_test.rb @@ -50,11 +50,16 @@ class SearchTest < SystemTest end end - setup { Rubygem.per_page = 2 } + setup do + 3.times do |i| + rubygem = create(:rubygem, name: "ruby#{i}", number: '1.0.0') + rubygem.gem_download.update(count: i) + end + Rubygem.per_page = 2 + end teardown { Rubygem.per_page = 30 } test "params has non white listed keys" do - (1..3).map { |i| create(:rubygem, name: "ruby#{i}", number: '1.0.0') } visit '/search?query=ruby&script_name=javascript:alert(1)//' assert page.has_content? "ruby1" assert page.has_content? "ruby2" From 9703fe95dc9c5e161a4bff4e92b501115e5b9d01 Mon Sep 17 00:00:00 2001 From: Laurent Arnoud Date: Sun, 13 Nov 2016 11:17:12 +0100 Subject: [PATCH 2/2] Improve search_test refute content ruby0 --- test/integration/search_test.rb | 1 + 1 file changed, 1 insertion(+) diff --git a/test/integration/search_test.rb b/test/integration/search_test.rb index 7bf7591bfc7..059bcb60e9c 100644 --- a/test/integration/search_test.rb +++ b/test/integration/search_test.rb @@ -61,6 +61,7 @@ class SearchTest < SystemTest test "params has non white listed keys" do visit '/search?query=ruby&script_name=javascript:alert(1)//' + refute page.has_content? "ruby0" assert page.has_content? "ruby1" assert page.has_content? "ruby2" assert page.has_link?("Next", href: "/search?page=2&query=ruby")