Prevent stats page error when no downloads#1259
Merged
dwradcliffe merged 1 commit intoMay 2, 2016
Merged
Conversation
If the stats page was visited while there were no downloads in the database, a NoMethodError would be thrown due to `@most_downloaded.first` being nil. This commit prevents this by checking it is available before accessing it. While this issue wouldn't occur in production it could in development after following the standard instructions for setting up a development environment in CONTRIBUTING.md.
Member
|
Did you try this locally? I think this will still error when the view tries to use the |
Contributor
Author
|
I have viewed this and it works fine locally when the stats page is viewed. I believe it doesn't error as |
Member
|
Ah yes you are right. 👍 Thanks! Also note: we will be adding the gem_downloads table to the database dumps soon, but this is good for now. |
Member
|
thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix for an issue mentioned in #1238.
If the stats page was visited while there were no downloads in the database, a
NoMethodErrorwould be thrown due to@most_downloaded.firstbeing nil. This commit prevents this by checking it is available before accessing it.While this issue wouldn't occur in production it could in development after following the standard instructions for setting up a development environment in
CONTRIBUTING.md.