Skip to content
This repository was archived by the owner on Apr 14, 2021. It is now read-only.

Commit 914a4a8

Browse files
committed
Auto merge of #6161 - bundler:indirect/update-pr-docs, r=segiddins
Stop requesting changelogs in PRs We added this requirement before the changelog was automated. Now that the changelog generated by a script, it's not helpful for PRs to update the changelog anymore, so we shouldn't expect it anymore. ### What was the end-user problem that led to this PR? We had to [ask a PR to remove a changelog entry](#6157 (comment)), even though the PR was following [the docs](https://github.com/bundler/bundler/blob/374caf6ede2cf4de7d2196aa2e2adef782bea5bd/doc/development/PULL_REQUESTS.md#changelogmd). ### What was your diagnosis of the problem? It looks like we failed to update the docs when we automated generating the changelog. ### What is your fix for the problem, implemented in this PR? Removing the changelog requirement from the docs hopefully means that future PRs will not include changelog entries, and we can generate future changelogs automatically. ### Why did you choose this fix out of the possible options? I chose this fix because it seemed like the smallest change that would accomplish the goal. /cc @mattbrictson
2 parents 892a637 + 3b6bf52 commit 914a4a8

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

doc/development/PULL_REQUESTS.md

-4
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,3 @@ Please ensure that the commit messages included in the pull request __do not__ h
3434
If you want to use these mechanisms, please instead include them in the pull request description. This prevents multiple notifications or references being created on commit rebases or pull request/branch force pushes.
3535

3636
Additionally, do not use `[ci skip]` or `[skip ci]` mechanisms in your pull request titles/descriptions or commit messages. Every potential commit and pull request should run through Bundler's CI system. This applies to all changes/commits (ex. even a change to just documentation or the removal of a comment).
37-
38-
## CHANGELOG.md
39-
40-
Don't forget to add your changes into the CHANGELOG! If you're submitting documentation, note the changes under the "Documentation" heading.

0 commit comments

Comments
 (0)