Rails 6!

[chaserx]

Rails 6 is out.

Should we? I think it won't be too bad

[benreyn]

The thing that Im concerned about is the "webpacker by default" business. (We've been through this at my day job, and it can be a bit of a pain)

[kdreyeroren]

If we're confident about our test coverage, it's always worth shoving it in and seeing how many tests fail!

[cassianoblonski]

Just started this and pretty much all the specs are ok, only the controller ones are failing¹. #149 cover the conversion of partners_ controller_spec.rb to a request spec, the other 2 specs failing are:
partner_requests_controller_spec.rb and static_controller_spec.rb. One thing that I need a response is about annotate, currently the gem does not support rails 6, so I commented it out from the Gemfile temporarily to continue with the process.

I'm gonna provide my rails 6 branch or a WIP-PR soon for anyone willing to test locally and see if something out of the coverage is not right, then start this conversion on a separately PR first then continue with the upgrade.

¹ rspec/rspec-rails#2086 (if I'm not mistaken RSpec 4.0 will cover this issue)

[jeduardo824]

#172 with me

[renanbona]

Can I work on this issue?

[benreyn]

I would coordinate with @edwinthinks. I believe he started a new effort to upgrade to Rails 6. (its possibly already ready? #288)

[edwinthinks]

I would coordinate with @edwinthinks. I believe he started a new effort to upgrade to Rails 6. (its possibly already ready? #288)

@benreyn possibly. The tests went green but I have yet to test it locally. I'll follow up here :)

Ahh my bad, I didn't perform the upgrade properly. Now that I have, tests are broken so I'll work through them. @renanbona I'll reach out for assistance if the failing tests are many!

[edwinthinks]

Update here, I've run the update (correctly this time) and tested the branch locally. So far things seem to work. I could use some extra eyes on this one - #288