Skip to content

Optionally send a email to diaper banks on every request made so they don't miss it #3325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
5 tasks
scooter-dangle opened this issue Jan 15, 2023 · 16 comments · Fixed by #4917
Closed
5 tasks

Comments

@scooter-dangle
Copy link
Collaborator

Summary

Allow essentials banks to opt in to having an email sent to them whenever a partner submits a request.

Why

The larger banks will not need this, but it could be useful for smaller banks with a smaller partner footprint.

Details

  • Add the ability to opt in to receiving emails on request submission
  • If opting in, the email goes to the bank's contact email

Things you need to know/consider

Should we use roles to accomplish this?

Criteria for completion

  • Banks can opt in to receiving an email whenever a partner submits a request
  • If they opt out, the primary address will no longer get that email
  • Test to verify this functionality

Notes /Questions

This was on the "project initiative" list so it originated before... April 2022?
CLF 20220809 An email? or would a text message be better? May need option for either
CLF 20221212 Question for development team - do we have the capability to send text messages? Answer -- don't think we do at this moment, and it would probably require an external service. Given that, I suggest that we don't implement text up front, but see if there is a demand for it before considering it.
CLF 20221212 How many banks would this be useful for (prioritization)
CLF 20221212 Idea - Would this be a role-based thing?
CLF 20221212 If the user is deactivated, would we need to ensure that at least one user is occupying that role? (we do that for org_admin, I expect, but only by not allowing org_admins to demote themselves)
Scott 20230115 Would we have verbiage in the email about how to stop receiving these emails?

@scooter-dangle scooter-dangle added the Help Wanted Groomed + open to all! label Jan 22, 2023
@nadineah
Copy link

Hi, can I take a shot at this? :)

@dorner
Copy link
Collaborator

dorner commented Apr 21, 2023

@nadineah you already have #3426 assigned - do you want both? Or would you rather focus on one at a time?

@nadineah
Copy link

@dorner My bad, one at a time would be better

@MasumaJaffery
Copy link

Hello, I would like to contribute in this issue and try my best to solve this!
Thank You.

@dorner
Copy link
Collaborator

dorner commented Jan 8, 2024

Give it a go!

@github-actions github-actions bot removed the Help Wanted Groomed + open to all! label Jan 8, 2024
Copy link
Contributor

github-actions bot commented Feb 8, 2024

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

Copy link
Contributor

Automatically unassigned after 7 days of inactivity.

@MasumaJaffery
Copy link

@dorner Please assign me this issue again, Thank You!

@Benjamin-Couey
Copy link
Contributor

May I work on this one?

@cielf
Copy link
Collaborator

cielf commented Dec 15, 2024

Please do.

@github-actions github-actions bot removed the Help Wanted Groomed + open to all! label Dec 15, 2024
@Benjamin-Couey
Copy link
Contributor

Given that the existing PR is incomplete, has a number of unresolved issues, and is far behind main, would it be appropriate to start with a fresh branch and PR? What is the recommended course of action in this case?

@cielf
Copy link
Collaborator

cielf commented Dec 16, 2024

Oh yes, please. IIRC, they were going down a wrong road.

@Benjamin-Couey
Copy link
Contributor

Benjamin-Couey commented Dec 16, 2024

Is the field Organization.email the bank’s contact email the details are referring to? The consideration that this may be a role based feature makes me suspect that the contact email is instead a user’s email.

Also, there is already the RequestsConfirmationMailer set up to send a confirmation email to the partner and user making the request when a request is made. Should I simply modify RequestsConfirmationMailer to satisfy this issue (CC the organization if they have opted in) or create a separate mailer that emails exclusively the organization?

@cielf
Copy link
Collaborator

cielf commented Dec 17, 2024

Yes it is.
For background - this is mainly to benefit banks that are relatively small, and won't be in the system every day anyway. They do, however, monitor an email.

@cielf
Copy link
Collaborator

cielf commented Dec 17, 2024

I think you could modify the existing mailer. This email is prompted by the same thing, so it makes sense to me.

Copy link
Contributor

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants