Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add logins for brand new bank to contributing.md #4683

Open
1 task
cielf opened this issue Sep 30, 2024 · 8 comments
Open
1 task

add logins for brand new bank to contributing.md #4683

cielf opened this issue Sep 30, 2024 · 8 comments
Labels
Good First Issue Suitable for users that are newer or less experienced Help Wanted Groomed + open to all!

Comments

@cielf
Copy link
Collaborator

cielf commented Sep 30, 2024

Summary

Add the ids for sf_org to the contributing.md

Why?

Developers don't know what that bank is and what it is used for. We should explain it.

Details

Add another group of users to the Credential section of Contributing.md

Bank Users (brand new bank)
Organization Admin
Email: [email protected]
Password: password!

User
Email: [email protected]
Password: password!

Criteria for completion

  • information added to contributing.md
@cielf cielf added hacktoberfest Good First Issue Suitable for users that are newer or less experienced labels Sep 30, 2024
@sbpipb sbpipb self-assigned this Oct 4, 2024
@sbpipb
Copy link
Collaborator

sbpipb commented Oct 4, 2024

i'm trying to understand this issue, from what is written so far, there's a need to add new credentials to the documentation (contribution.md), this is for a user type that is "Brand new bank". What this implies is that the credentials should be available in seeders file as well, which actually is present in seeds.rb.

So this is merely updating documentation to add a variant of a Bank User, called brand new bank. did i get that right?

@sbpipb
Copy link
Collaborator

sbpipb commented Oct 4, 2024

I'm trying to understand what "Add the ids for sf_org to the contributing.md" mean, is it just the Organization id of the actual SF org?

from the code base

  organization.name    = "SF Diaper Bank"
  organization.street  = "P.O. Box 12345"
  organization.city    = "San Francisco"
  organization.state   = "CA"
  organization.zipcode = "90210"
  organization.email   = "[email protected]"
end
Organization.seed_items(sf_org)

i'm missing the need for this, mainly cause i'm new to this project. i'm happy to work on this as well missing a few pieces to the big picture of things.

@cielf
Copy link
Collaborator Author

cielf commented Oct 4, 2024

In the contributing.md, there is a a section for Bank Users, where the ids and passwords for the various roles live.

We would like to have the ids and passwords as specified in the issue added to that section. Essentially just as they have been specified in the issue. I would put the section between the current Bank Users section and the current Partner Users section. (I'm seeing it as somewhere around line 66).

@lsfernandes92
Copy link
Contributor

Sorry to jump in, but I just wanted to mention that this is the documentation section that this issue refers to: link. Hope it helps! :)

@lsfernandes92
Copy link
Contributor

lsfernandes92 commented Oct 14, 2024

What's the status of this one? I would like to pick this one if you don't intend to @sbpipb

Copy link
Contributor

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

Copy link
Contributor

Automatically unassigned after 7 days of inactivity.

@cielf
Copy link
Collaborator Author

cielf commented Nov 21, 2024

@lsfernandes92 Are you still interested in this one?

@cielf cielf added Help Wanted Groomed + open to all! and removed stale labels Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Suitable for users that are newer or less experienced Help Wanted Groomed + open to all!
Projects
None yet
Development

No branches or pull requests

3 participants