Fix CircleCI

Author: schneems

.circleci/config.yml

@@ -10,31 +10,25 @@ references:
 jobs:
   "ruby-2-5":
     docker:
-      - image: 'cimg/base:stable'
+      - image: circleci/ruby:2.5
     steps:
       - checkout
-      - ruby/install:
-          version: "2.5"
       - ruby/install-deps
       - <<: *unit
 
   "ruby-2-6":
     docker:
-      - image: 'cimg/base:stable'
+      - image: circleci/ruby:2.6
     steps:
       - checkout
-      - ruby/install:
-          version: "2.6"
       - ruby/install-deps
       - <<: *unit
 
   "ruby-2-7":
     docker:
-      - image: 'cimg/base:stable'
+      - image: circleci/ruby:2.7
     steps:
       - checkout
-      - ruby/install:
-          version: "2.7"
       - ruby/install-deps
       - <<: *unit
 

lib/syntax_search.rb

@@ -16,6 +16,7 @@ def self.handle_error(e, search_source_on_error: SEARCH_SOURCE_ON_ERROR_DEFAULT)
 
     filename = e.message.split(":").first
 
+    $stderr.sync = true
     $stderr.puts "Run `$ syntax_search #{filename}` for more options\n"
 
     if search_source_on_error

spec/unit/exe_spec.rb

@@ -15,7 +15,7 @@ def exe(cmd)
     it "parses valid code" do
       ruby_file = exe_path
       out = exe(ruby_file)
-      expect(out.strip).to eq("Syntax OK")
+      expect(out.strip).to include("Syntax OK")
     end
 
     it "parses invalid code" do

spec/unit/syntax_search_spec.rb

@@ -8,11 +8,7 @@ module SyntaxErrorSearch
       expect(SyntaxErrorSearch::VERSION).not_to be nil
     end
 
-    def run_ruby(script)
-      `ruby -I#{lib_dir} -rsyntax_search/auto #{script} 2>&1`
-    end
-
-    it "detects require error and adds a message" do
+    it "detects require error and adds a message with auto mode" do
       Dir.mktmpdir do |dir|
         @tmpdir = Pathname(dir)
         @script = @tmpdir.join("script.rb")
@@ -34,23 +30,19 @@ def run_ruby(script)
           require_relative "./script.rb"
         EOM
 
-        out = run_ruby(require_rb)
-        # puts out
+        out = `ruby -I#{lib_dir} -rsyntax_search/auto #{require_rb} 2>&1`
 
+        expect(out).to include("This code has an unmatched")
         expect(out).to include("Run `$ syntax_search")
+        expect($?.success?).to be_falsey
       end
     end
 
-    it "detects require error and adds a message when executed via bundler auto" do
+    it "detects require error and adds a message with fyi mode" do
       Dir.mktmpdir do |dir|
-        dir = Pathname(dir)
-        gemfile = dir.join("Gemfile")
-        gemfile.write(<<~EOM)
-          gem "syntax_search", path: "#{root_dir}", require: "syntax_search/auto"
-        EOM
-        run!("BUNDLE_GEMFILE=#{gemfile} bundle install --local")
-        script = dir.join("script.rb")
-        script.write <<~EOM
+        @tmpdir = Pathname(dir)
+        @script = @tmpdir.join("script.rb")
+        @script.write <<~EOM
           describe "things" do
             it "blerg" do
             end
@@ -63,59 +55,16 @@ def run_ruby(script)
           end
         EOM
 
-        Bundler.with_original_env do
-          require_rb = dir.join("require.rb")
-          require_rb.write <<~EOM
-            Bundler.require
-
-            require_relative "./script.rb"
-          EOM
-
-          out = `BUNDLE_GEMFILE=#{gemfile} bundle exec ruby #{require_rb} 2>&1`
-
-          expect($?.success?).to be_falsey
-          expect(out).to include("This code has an unmatched")
-          expect(out).to include("Run `$ syntax_search")
-        end
-      end
-    end
-
-    it "detects require error and adds a message when executed via bundler fyi" do
-      Dir.mktmpdir do |dir|
-        dir = Pathname(dir)
-        gemfile = dir.join("Gemfile")
-        gemfile.write(<<~EOM)
-          gem "syntax_search", path: "#{root_dir}", require: "syntax_search/fyi"
-        EOM
-        run!("BUNDLE_GEMFILE=#{gemfile} bundle install --local")
-        script = dir.join("script.rb")
-        script.write <<~EOM
-          describe "things" do
-            it "blerg" do
-            end
-
-            it "flerg"
-            end
-
-            it "zlerg" do
-            end
-          end
+        require_rb = @tmpdir.join("require.rb")
+        require_rb.write <<~EOM
+          require_relative "./script.rb"
         EOM
 
-        Bundler.with_original_env do
-          require_rb = dir.join("require.rb")
-          require_rb.write <<~EOM
-            Bundler.require
+        out = `ruby -I#{lib_dir} -rsyntax_search/fyi #{require_rb} 2>&1`
 
-            require_relative "./script.rb"
-          EOM
-
-          out = `BUNDLE_GEMFILE=#{gemfile} bundle exec ruby #{require_rb} 2>&1`
-
-          expect($?.success?).to be_falsey
-          expect(out).to_not include("This code has an unmatched")
-          expect(out).to include("Run `$ syntax_search")
-        end
+        expect(out).to_not include("This code has an unmatched")
+        expect(out).to include("Run `$ syntax_search")
+        expect($?.success?).to be_falsey
       end
     end
   end