Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't cache JRuby runtime in static fields #707

Open
headius opened this issue Nov 20, 2024 · 0 comments
Open

Don't cache JRuby runtime in static fields #707

headius opened this issue Nov 20, 2024 · 0 comments
Assignees

Comments

@headius
Copy link
Contributor

headius commented Nov 20, 2024

There are a few places where we cache the JRuby runtime or runtime-specific objects in a static field, such as here with a WeakReference:

public static RuntimeInfo forRuntime(Ruby runtime) {
synchronized (RuntimeInfo.class) {
if (runtime1.get() == runtime) return info1;
RuntimeInfo cache = null;
if (runtimes != null) cache = runtimes.get(runtime);
assert cache != null : "Runtime given has not initialized JSON::Ext";
return cache;
}
}

The runtimes cached in weak references will not "leak" but it may take longer for the runtime to be collected than normal. In addition, the cost of traversing the weak reference may offset any gains from caching runtime objects.

These should be removed and cached in a runtime-safe way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant