Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit a deprecation warning when dealing with incorrectly encoded strings #642

Closed
2 tasks
byroot opened this issue Oct 24, 2024 · 0 comments · Fixed by #643
Closed
2 tasks

Emit a deprecation warning when dealing with incorrectly encoded strings #642

byroot opened this issue Oct 24, 2024 · 0 comments · Fixed by #643
Milestone

Comments

@byroot
Copy link
Member

byroot commented Oct 24, 2024

Ref: #138

Because it was initially implemented for Ruby 1.8 which didn't have proper string encoding, in a bunch of places the C version does silently accept strings with broken encodings.

We should emit a deprecation warning in 2.8.0, and remove that mis-feature in 3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant