json 2.3.1 accepts { and [ as valid JSON

[peterkinmond]

JSON.parse 2.3.1 accepts { and [ as valid JSON, which caused a JSON::ParserError in 2.3.0.

2.3.0

> JSON.parse('{') # => JSON::ParserError: 783: unexpected token at '{'
> JSON.parse('[') # => JSON::ParserError: 434: unexpected token at ''
> JSON.parse('') # => JSON::ParserError: 783: unexpected token at ''
> JSON.parse('{}') # => {}
> JSON.parse('[]') # => []
> JSON.parse('{{}') # => JSON::ParserError: 783: unexpected token at '{{}'

2.3.1

> JSON.parse('{') # => {}
> JSON.parse('[') # => []
> JSON.parse('') # => JSON::ParserError: source is not valid JSON!
> JSON.parse('{}') # => {}
> JSON.parse('[]') # => []
> JSON.parse('{{}') # => JSON::ParserError: unexpected token in object at '{}'!

[marcandre]

This would indicate that there is something wrong with the test suite, as I added these tests in 5b4f1ba

[peterkinmond]

@marcandre it looks like 5b4f1ba didn't get included in the 2.3.1 release:

2.3.1 lists the sha as 0951d77 which doesn't include those test files (tests/fixtures/fail29.json, etc)

[marcandre]

Ho, right, my fix just hasn't been released yet.
I guess that when you were running it in 2.3.0 it was using the C/Java implementation, and in 2.3.1 it is using the Ruby-pure implementation, which had this bug, which was fixed by #425.
In that case, this issue can be fixed as already solved, we'll just hope for a release.

[peterkinmond]

Makes sense, thanks! I'll close this issue