Merge pull request #49 from amatsuda/perf1

tenderlove · web-flow · commit 75dc02fe27a7 · 2024-02-23T09:56:02.000-08:00
Prefer String#start_with? over Regexp.match
diff --git a/lib/ipaddr.rb b/lib/ipaddr.rb
@@ -674,7 +674,7 @@ def in_addr(addr)
     end
     octets.inject(0) { |i, s|
       (n = s.to_i) < 256 or raise InvalidAddressError, "invalid address: #{@addr}"
-      s.match(/\A0./) and raise InvalidAddressError, "zero-filled number in IPv4 address is ambiguous: #{@addr}"
+      (s != '0') && s.start_with?('0') and raise InvalidAddressError, "zero-filled number in IPv4 address is ambiguous: #{@addr}"
       i << 8 | n
     }
   end

Original file line number	Diff line number	Diff line change
`@@ -674,7 +674,7 @@ def in_addr(addr)`
`674`	`674`	`end`
`675`	`675`	`octets.inject(0) { \|i, s\|`
`676`	`676`	`(n = s.to_i) < 256 or raise InvalidAddressError, "invalid address: #{@addr}"`
`677`		`- s.match(/\A0./) and raise InvalidAddressError, "zero-filled number in IPv4 address is ambiguous: #{@addr}"`
	`677`	`+ (s != '0') && s.start_with?('0') and raise InvalidAddressError, "zero-filled number in IPv4 address is ambiguous: #{@addr}"`
`678`	`678`	`i << 8 \| n`
`679`	`679`	`}`
`680`	`680`	`end`