Logging too verbose

[elsurudo]

What do you think of having the following messages show up only when the "verbose" option is specified:

• Looking for new messages ...
• No message found for ...

They are usually just noise, since they happen all the time, even when no jobs are being processed...

Or perhaps we can make it a config option, in the YML?

What do you think?

[phstc]

hm basically moving these messages from .info to .debug?

Do you think we can output something else time-to-time just to know that the process isn't stuck when tailing servers? We can use kill -TTIN but it's more complexity.

[elsurudo]

Moving them to debug is the solution I would go with, but it sounds like you may want to keep these in your logs, so some sort of configuration option would accommodate both.

As for outputting something just to know that it isn't dead – seems kind of hacky... not the right tool for the job.

Perhaps we can output some statistics once in a while, but it still seems a bit forced.

I definitely want to get rid of these from my logs though, because they drown out all the useful messages!

[phstc]

is thinking on that ^^^

[phstc]

I'm tending to move these messages to the DEBUG level -v, as we can also check if the processes is alive through the timing middleware: "started at" and "completed in".

https://github.com/phstc/shoryuken/blob/master/lib/shoryuken/middleware/server/timing.rb

[elsurudo]

Good point. And it looks like Timing is included as part of default middleware, too.

Well, I already have a branch where I moved these to debug for my own purposes, so let me just push that up and make a PR...