Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positive for RSpec/RedundantPredicateMatcher at be_respond_to(:method, true) #2010

Open
Tietew opened this issue Dec 20, 2024 · 1 comment

Comments

@Tietew
Copy link
Contributor

Tietew commented Dec 20, 2024

Expected behavior

Following usage is allowed:

it 'responds to bar' do
  expect(subject).to be_respond_to(:a_private_method, true)
end

This tests the subject responds to a private method a_private_method.

Actual behavior

RSpec/RedundantPredicateMatcher detected and autocorrected to respond_to(:symbol, true)

it 'responds to bar' do
  expect(subject).to respond_to(:a_private_method, true)
end

raises following error:

    Failure/Error: expect(subject).to respond_to(:a_private_method, true)
    TypeError:
       true is not a symbol nor a string

Because respond_to matcher accepts list of method symbols.
https://www.rubydoc.info/gems/rspec-expectations/RSpec%2FMatchers:respond_to

Steps to reproduce the problem

Run rubocop on:

it 'responds to bar' do
  expect(subject).to be_respond_to(:a_private_method, true)
end

RuboCop RSpec version

$ be rubocop -V
1.69.2 (using Parser 3.3.6.0, rubocop-ast 1.37.0, analyzing as Ruby 3.1, running on ruby 3.3.6) [x86_64-linux]
  - rubocop-capybara 2.21.0
  - rubocop-factory_bot 2.26.1
  - rubocop-i18n 1.14.6
  - rubocop-performance 1.23.0
  - rubocop-rails 2.27.0
  - rubocop-rake 0.6.0
  - rubocop-rspec 3.3.0
  - rubocop-rspec_rails 2.30.0
@pirj
Copy link
Member

pirj commented Dec 20, 2024

Can you please provided more details, what are you testing exactly?

I understand what the problem is, but at a glance it’s unlikely that the respond_to matcher is designed to check private methods. And, presumably, for a reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants