Add new cop Lint/OrAssignmentToConstant

[uplus]

This cop checks unintended or-assignment to constant.
Usually, you don't need to consider whether A is already assigned elsewhere.

# bad
CONST ||= 1

# good
CONST = 1

---

Before submitting the PR make sure the following are checked:

• The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
• Wrote good commit messages.
• Commit message starts with [Fix #issue-number] (if the related issue exists).
• Feature branch is up-to-date with master (if not - rebase it).
• Squashed related commits together.
• Added tests.
• Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
• Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

[dvandersluis]

Looks like a useful cop!

[uplus]

Thank you for review.
I fixed the three places you pointed out, resolved conflicts, and squashed them.

[dvandersluis]

LGTM, thanks 👍

@rubocop-hq/rubocop-core ci/circleci: cc-upload-coverage keeps failing on this PR, anyone have any ideas why?

[koic]

ci/circleci: cc-upload-coverage keeps failing on this PR, anyone have any ideas why?

It's possible that Code Climate's API wasn't working properly. I think this failure can be ignored.

#!/bin/bash -eo pipefail
./tmp/cc-test-reporter sum-coverage tmp/codeclimate.*.json --parts 6 --output tmp/codeclimate.total.json
./tmp/cc-test-reporter upload-coverage --input tmp/codeclimate.total.json
Error: response from https://api.codeclimate.com/v1/test_reports.
HTTP 401: You are not authorized for this action
Usage:
  cc-test-reporter upload-coverage [flags]

Flags:
  -s, --batch-size int    batch size for source files (default 500)
  -e, --endpoint string   endpoint to upload coverage information to (default "https://api.codeclimate.com/v1/test_reports")
  -r, --id string         reporter identifier (default "a11b66bfbb1acdf220d5cb317b2e945a986fd85adebe29a76d411ad6d74ec31f")
  -i, --input string      input path (default "coverage/codeclimate.json")
      --insecure          send coverage insecurely (without HTTPS)

Global Flags:
  -d, --debug   run in debug mode


Exited with code exit status 255
CircleCI received exit code 255

[dvandersluis]

@koic yeah that’s what I figured but I wanted to double check, thanks.