Add new Lint/RedundantDirGlobSort cop#9301
Merged
bbatsov merged 1 commit intorubocop:masterfrom Dec 31, 2020
Merged
Conversation
koic
force-pushed
the
add_new_lint_redundant_dir_glob_sort_cop
branch
from
a4b38b2 to
3021748
Compare
Sort globbed results by default in Ruby 3.0. https://bugs.ruby-lang.org/issues/8709 This PR adds new `Lint/RedundantDirGlobSort` cop. It checks for redundant `sort` method to `Dir.glob` and `Dir[]`. ```ruby # bad Dir.glob('./lib/**/*.rb').sort.each do |file| end Dir['./lib/**/*.rb'].sort.each do |file| end # good Dir.glob('./lib/**/*.rb').each do |file| end Dir['./lib/**/*.rb'].each do |file| end # good - Respect intent if `sort` keyword option is specified. Dir.glob('./lib/**/*.rb', sort: false).each do |file| end ``` Related PR rubocop#9300.
koic
force-pushed
the
add_new_lint_redundant_dir_glob_sort_cop
branch
from
3021748 to
adfea8c
Compare
Collaborator
|
Nicely done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sort globbed results by default in Ruby 3.0.
https://bugs.ruby-lang.org/issues/8709
This PR adds new
Lint/RedundantDirGlobSortcop.It checks for redundant
sortmethod toDir.globandDir[].Related PR #9300.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.