Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standalone tool and tests broken on MacOS/golang1.8 #81

Closed
KlausVii opened this issue Jun 15, 2017 · 4 comments
Closed

Standalone tool and tests broken on MacOS/golang1.8 #81

KlausVii opened this issue Jun 15, 2017 · 4 comments

Comments

@KlausVii
Copy link

Trying to run the standalone client on MacOS does this:

sql-migrate
[1]    88703 killed     sql-migrate

Also running the tests in rubenv/sql-migrate fail

src/github.com/rubenv/sql-migrate: go test ./...

signal: killed
FAIL    github.com/rubenv/sql-migrate    0.008s
signal: killed
FAIL    github.com/rubenv/sql-migrate/sql-migrate    0.007s
ok      github.com/rubenv/sql-migrate/sqlparse    0.007s

The culprit should be one of the last couple of commits, since I've been using this tool without issue for a while.

@KlausVii
Copy link
Author

KlausVii commented Jun 15, 2017

Found a workaround sql-migrate needs to be installed with these flags
go install -ldflags -s

I think the issue was this commit: 42c30aa
With the change from os to net/http for opening files,

sql-migrate was exposed to this issue:
golang/go#19734 where this is the solution golang/go#11887

UPDATE: Actually removing that commit did not fix the issue, so I'm not sure of the root cause, but building with -ldflags -s at least works.

@rubenv
Copy link
Owner

rubenv commented Jun 15, 2017

Reading the issue, it seems that Go 1.8.1 fixes things. I'm running 1.8.3 and am not seeing issues. Could you give a newer Go a go?

@KlausVii KlausVii changed the title Standalone tool and tests broken on MacOS Standalone tool and tests broken on MacOS/golang1.8 Jun 19, 2017
@KlausVii
Copy link
Author

Yeah I was running go1.8, seems updating to 1.8.3 solved the issue.

@rubenv
Copy link
Owner

rubenv commented Jun 19, 2017

Cool, thanks!

@rubenv rubenv closed this as completed Jun 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants