Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize Code Explorer context menu icon size #5238

Open
IvenBach opened this issue Oct 22, 2019 · 4 comments · May be fixed by #6251
Open

Standardize Code Explorer context menu icon size #5238

IvenBach opened this issue Oct 22, 2019 · 4 comments · May be fixed by #6251
Labels
bug Identifies work items for known bugs difficulty-01-duckling Issue where no particularly involved knowledge of the internal API is needed. enhancement Feature requests, or enhancements to existing features. Ideas. Anything within the project's scope. user-interface This issue explicitly relates to the visible interface of Rubberduck.

Comments

@IvenBach
Copy link
Member

Rubberduck version information
Version 2.4.1.21624
OS: Microsoft Windows NT 6.1.7601 Service Pack 1, x64
Host Product: Microsoft Office 2013 x86
Host Version: 15.0.5023.1000
Host Executable: EXCEL.EXE

Description
The images are slightly different sizes setting off my OCD. Spacing for text between UserForm and Standard module and Class Module shows the different sizing.

To Reproduce
Steps to reproduce the behavior:

  1. Right click within Code Explorer > Add

Expected behavior
Icons should be the same dimensions.

Screenshots
Code explorer standardize icon size
@IvenBach IvenBach added the difficulty-01-duckling Issue where no particularly involved knowledge of the internal API is needed. label Oct 22, 2019
@Vogel612 Vogel612 added enhancement Feature requests, or enhancements to existing features. Ideas. Anything within the project's scope. user-interface This issue explicitly relates to the visible interface of Rubberduck. labels Oct 22, 2019
@MDoerner
Copy link
Contributor

For me (Excel 2019 64bit), the icons look the same size.

CEContextMenu

@MDoerner
Copy link
Contributor

This seems to be a Win7 WPF issue. As can be seen above, there is no problem in Win 10.

@IvenBach
Copy link
Member Author

Tested on a Win10 machine. Confirm that the context menu has icons with the correct size. Unfortunately the top menu does not have the correct sizes.
Images not display correctly from top add method

Also when the context menu is displayed then the top menu is shown all icons are missing. This behavior was consistent for Win7 and Win10 machines both. Resolution was to close host application (Excel is my tests) and restart.
CodeExplorer icons missing

@MDoerner
Copy link
Contributor

The missing menu behaviour can also go the other way around with the contex submenu for add missing.

EmptyAddContextMenu

The two manues seem to interfere. The issue arises once both manues have been opened. The manu opened first will be empty once the other one has been opened.

@IvenBach IvenBach added the bug Identifies work items for known bugs label Oct 31, 2019
@MDoerner MDoerner mentioned this issue Nov 10, 2019
Closed
@IvenBach IvenBach linked a pull request Feb 11, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Identifies work items for known bugs difficulty-01-duckling Issue where no particularly involved knowledge of the internal API is needed. enhancement Feature requests, or enhancements to existing features. Ideas. Anything within the project's scope. user-interface This issue explicitly relates to the visible interface of Rubberduck.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add explicit image size constraint for CodeExplorer>Add menu IvenBach/Rubberduck
3 participants
@Vogel612 @MDoerner @IvenBach