Review

Author: romancardenas

examples/hifive1/Cargo.toml

@@ -13,7 +13,6 @@ rtic = { path = "../../rtic" }
 heapless = "0.8.0"
 hifive1 = { git = "https://github.com/romancardenas/hifive1.git", features = ["board-redv"] }
 e310x = { git = "https://github.com/greenlsi/e310x.git", features = ["rt"]}
-# riscv-rt = {path = "../../../riscv/riscv-rt", features = ["single-hart"]}
 riscv-rt = {version = "0.12.1", features = ["single-hart"]}
 riscv = "0.11.0"
 semihosting = { version = "0.1", features = ["stdio", "panic-handler"] }

examples/hifive1/examples/prio_inheritance.rs

@@ -1,6 +1,5 @@
 #![no_main]
 #![no_std]
-// #![feature(type_alias_impl_trait)]
 
 use riscv_rt as _;
 

examples/hifive1/examples/static.rs

@@ -4,7 +4,6 @@
 #![deny(warnings)]
 #![deny(unsafe_code)]
 #![deny(missing_docs)]
-// #![feature(type_alias_impl_trait)]
 
 use hifive1 as _;
 use riscv_rt as _;

examples/hifive1/examples/task.rs

@@ -4,7 +4,6 @@
 #![deny(warnings)]
 #![deny(unsafe_code)]
 #![deny(missing_docs)]
-// #![feature(type_alias_impl_trait)]
 
 use hifive1 as _;
 use riscv_rt as _;

examples/hifive1/examples/zero_prio_task.rs

@@ -4,7 +4,6 @@
 #![deny(warnings)]
 #![deny(unsafe_code)]
 #![deny(missing_docs)]
-// #![feature(type_alias_impl_trait)]
 
 use core::marker::PhantomData;
 use hifive1 as _;

rtic-macros/CHANGELOG.md

@@ -11,8 +11,8 @@ For each category, *Added*, *Changed*, *Fixed* add new entries at the top!
 
 ### Added
 
-- RTIC v2 now works on stable.
 - Unstable support for RISC-V targets compatible with `riscv-slic`
+- RTIC v2 now works on stable.
 - Unstable ESP32-C3 support.
 
 ### Changed

rtic-macros/src/codegen/bindings/riscv_slic.rs

@@ -161,7 +161,7 @@ pub fn architecture_specific_analysis(app: &App, _analysis: &SyntaxAnalysis) ->
         ));
     }
 
-    Ok(()) // TODO
+    Ok(())
 }
 
 /// Macro to add statements to be executed at the beginning of all the interrupt handlers.

rtic-monotonics/CHANGELOG.md

@@ -9,8 +9,8 @@ For each category, *Added*, *Changed*, *Fixed* add new entries at the top!
 
 ### Changed
 
+- Tweak `build.rs` to avoid warnings in Nightly 1.78+
 - Removed unused `rust-toolchain.toml`
-Tweak `build.rs` to avoid warnings in Nightly 1.78+
 
 ## v1.5.0 - 2024-01-10
 

rtic/Cargo.toml

@@ -31,7 +31,6 @@ features = ["rtic-macros/test-template"]
 name = "rtic"
 
 [dependencies]
-# riscv-slic = { path = "../../riscv-slic/riscv-slic", optional = true }
 riscv-slic = { git = "https://github.com/romancardenas/riscv-slic.git", rev = "2a91edb", optional = true }
 esp32c3 = { version = "0.20.0", optional = true}
 riscv = {version = "0.11.0", optional = true}

rtic/src/export/riscv_common.rs

@@ -1,5 +1,4 @@
 /// GENERIC RE-EXPORTS: needed for all RTIC backends
-// pub use riscv::interrupt;
 
 /// Read the stack pointer.
 #[inline(always)]