-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor the Server project #78
base: main
Are you sure you want to change the base?
Conversation
我通过 |
看到一处代码,不确定这个是不是bug >>> //TODO check is correct? not req.AgoraAsrLanguage?
>>> language := gjson.Get(manifestJson, `predefined_graphs.0.nodes.#(name=="agora_rtc").property.agora_asr_language`).String()
manifestJson, err = tts.ProcessManifest(manifestJson, common.Language(language), req.VoiceType)
if err != nil {
slog.Error("handlerStart tts ProcessManifest failed", "err", err, "requestId", req.RequestId, logTag)
return "", "", err
}
... |
@Lensual 这里再进行获取 逻辑上没问题 |
@Lensual |
Keep it going, I like to see this kinds of talk. |
也许前端提供一个 |
@Lensual |
这个提交是不是过大了,需要拆分吗 |
@Lensual Right, we updated a few things. Merge the latest changes into your branch and see if you can split the code into smaller chunks for a better review. |
I was wrong, :P |
This PR needs to be updated. |
server
project structure