Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash in Godot 4.3rc2 #98

Closed
plyoung opened this issue Aug 6, 2024 · 2 comments
Closed

Crash in Godot 4.3rc2 #98

plyoung opened this issue Aug 6, 2024 · 2 comments

Comments

@plyoung
Copy link
Contributor

plyoung commented Aug 6, 2024

The addon will cause Godot 4.3rc2 to crash on startup of the editor when there are ControllerIconTexture resources.

I've tracked it down to ControllerIconTexture._load_texture_path() . Commenting out the deferred call seems to "resolve" the issue. I do not know enough about the intention here though so the problem might be somewhere else?

Anyway, this is what I did to get rid of the crash in case it helps identify the real cause.

func _load_texture_path():
	# Ensure loading only occurs on the main thread
	#if OS.get_thread_caller_id() != OS.get_main_thread_id():
	#	_load_texture_path_main_thread.call_deferred()
	#else:
	#	_load_texture_path_main_thread()
	_load_texture_path_main_thread()

[edit] oh I think it is being looked at here? #96

@rsubtil
Copy link
Owner

rsubtil commented Aug 6, 2024

It seems very likely to be related to #96. This is a Godot issue that was just fixed, so hopefully this is fixed for the next RC.

@rsubtil
Copy link
Owner

rsubtil commented Aug 7, 2024

#96 was now closed since this was fixed on the engine side; this is very likely the same problem, so I'll close this for now. For anyone else encountering this issue:

Note

This bug was introduced on v4.3.beta1, and it is present up until v4.3.rc2; the next RC release should fix this, so please wait for the next RC release, or use v4.3.dev6 for now.

@rsubtil rsubtil closed this as not planned Won't fix, can't repro, duplicate, stale Aug 7, 2024
@rsubtil rsubtil pinned this issue Aug 7, 2024
@rsubtil rsubtil unpinned this issue Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants