FontAwesome 5.1.0 update and fix to flexdashboard #1388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihui
added a commit
that referenced
this pull request
Jun 27, 2018
3 tasks
yihui
pushed a commit
to RLesur/rmarkdown
that referenced
this pull request
Apr 1, 2019
* Modify the included FontAwesome files * Update `html_dependency_font_awesome()`
yihui
added a commit
to RLesur/rmarkdown
that referenced
this pull request
Apr 1, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an update to the FontAwesome support in rmarkdown. It upgrades it to release 5.1.0.
This also fixes rstudio/flexdashboard#189. The fix is achieved by not including JS dependencies (this is the same implementation as in the v4.5.0 include of FA), so, webfonts will be used instead of SVG. This was tested and it restores the correct placement and sizing of icons in the flexdashboard
valueBox()s.