Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change all json data in docs folder to point to system.file(package = "leaflet") #576

Closed
schloerke opened this issue Aug 7, 2018 · 1 comment · Fixed by #747
Closed

Change all json data in docs folder to point to system.file(package = "leaflet") #576

schloerke opened this issue Aug 7, 2018 · 1 comment · Fixed by #747
Labels
difficulty: novice Anyone could help docs Related to documentation only effort: low < 1 day of work help wanted Solution is well-specified enough that any community member could fix priority: medium Could be fixed before next release

Comments

@schloerke
Copy link
Contributor

Can't execute example: https://rstudio.github.io/leaflet/choropleths.html as folder 'json' doesn't exist. should be a system.file file.
@schloerke schloerke added help wanted Solution is well-specified enough that any community member could fix priority: medium Could be fixed before next release effort: low < 1 day of work docs Related to documentation only difficulty: novice Anyone could help labels Aug 7, 2018
@schloerke
Copy link
Contributor Author

The json files should be moved accordingly

@williamlai2 williamlai2 mentioned this issue Aug 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty: novice Anyone could help docs Related to documentation only effort: low < 1 day of work help wanted Solution is well-specified enough that any community member could fix priority: medium Could be fixed before next release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Examples load from json system file. Updated documentation and fixed broken web link.
1 participant
@schloerke