Drb exit status #335
Closed
Drb exit status #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 9, 2011 10:17
This change causes rspec to exit with a non-zero exit status when specs fail, even when running with DRb. Failover to local run is done by not catching DRb::DRbConnError exceptions in RSpec::Core::DRbCommandLine, instead letting them come up to Runner.run.
DRbCommandLine.run no longer outputs a connection error message, instead it lets raised DRbConnError exceptions pass through. Also it returns false for the dummy spec because of the raise() therein.
|
Merged. Thanks! |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are changes that make rspec exit with a non-zero exit status if specs fail in DRb runs. This time round I fixed the specs too.