Skip to content

Warn about naming my own build script estrella.js #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
maxkrieger opened this issue Mar 9, 2021 · 3 comments
Closed

Warn about naming my own build script estrella.js #31

maxkrieger opened this issue Mar 9, 2021 · 3 comments

Comments

@maxkrieger
Copy link

After about an hour of confusion I realized I should not be calling my build.js as estrella.js, since the package's own estrella.js will mistake it for running itself (

estrella/src/estrella.js

Line 1022 in 25f0486

== (DEBUG ? "estrella.g.js" : "estrella.js")
). This results in an unrelated missing <srcfile> argument (see ${prog} -help) error.

I think the README should at least warn about this, if the heuristic can't be changed. I imagine I'm not the only one calling the file estrella.js since there's the convention rollup.config.js and webpack.config.js.
@rsms
Copy link
Owner

rsms commented Mar 10, 2021

Oh good catch!

@rsms rsms closed this as completed in 8e27884 Mar 10, 2021
@rsms
Copy link
Owner

rsms commented Mar 10, 2021 •
edited
Loading

Will be included in the next release (1.4.0)

@rsms
Copy link
Owner

rsms commented Mar 12, 2021

Shipped with release 1.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rsms @maxkrieger