Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question to loop closing #101

Open
elorenz97 opened this issue Nov 8, 2024 · 4 comments
Open

Question to loop closing #101

elorenz97 opened this issue Nov 8, 2024 · 4 comments

Comments

@elorenz97
Copy link

Hello,
First of all, thank you for creating this lidar-based SLAM. In particular, that it works for ROS2 Humble. :)
So far, it's working really well. I use it with a Velodyne VLP-16 for outdoor use.

I want to show the differences between with and without loop closure, as you did in an example. But I'm a beginner with loop closing. So I've already noticed that the normal path is without loop closure and the modified path is with loop closing.
However, on the picture you can see that it looks like the modified path has a lower "resolution" than the yellow path. Especially in the curve it looks really bad.
But I don't know why? What parameter can I change to fix the problem?

Screenshot from 2024-11-08 12-03-34

@elorenz97 elorenz97 changed the title Quest to loop closing Question to loop closing Nov 8, 2024
@rsasaki0109
Copy link
Owner

The yellow path represents the LiDAR odometry path, and its frequency matches the LiDAR’s cycle.

The green path is a collection of poses used in graph optimization, which are downsampled compared to the yellow path. Loop closure is achieved by dividing the map into submaps, performing matching between submaps to search for loops, and the green path represents a collection of representative poses of these submaps.

Therefore, the lower resolution of the green path is by design. To increase the resolution, code modifications would be necessary.

@elorenz97
Copy link
Author

oh I understand.
Thank you for your explanation. :)

@elorenz97
Copy link
Author

But how did you achived this result?
https://github.com/rsasaki0109/lidarslam_ros2/blob/develop/lidarslam/images/path.png
Can I disabled loopclosure?

@elorenz97 elorenz97 reopened this Nov 11, 2024
@rsasaki0109
Copy link
Owner

rsasaki0109 commented Nov 11, 2024

The image is from an early test, and at that time, the test environment was small, so instead of looking for loops with a set of submaps, the implementation might have been set to look for loop closures directly between single scans.
Sorry about that—I wrote the code quite a while ago, so I don't remember all the details. I’ll check the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants