Skip to content

Conversation

@torie
Copy link
Contributor

@torie torie commented May 25, 2018

This add support for using the $in and $nin operators in the query package against array fields as described in #187.

It also adds tests for nested fields and the utils.getField function.

@smyrman smyrman requested a review from rs May 25, 2018 08:54
Copy link
Collaborator

@smyrman smyrman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smyrman
Copy link
Collaborator

smyrman commented May 25, 2018

@rs, this allows the mem backend to work more equal to how MongoDB works for $in and $nin queries, making it easier to write unit-tests when using that backend. I don't have any experience with the other rest-layer backends, such as e.g. elastic-search https://github.com/rs/rest-layer-es/blob/c9cca01e407ccc54e6f84f228ac0c45700c5cf96/query.go#L81.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants