Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bottleneck doesn't try to create output dir #28

Open
fjahr opened this issue Oct 24, 2021 · 0 comments
Open

Bottleneck doesn't try to create output dir #28

fjahr opened this issue Oct 24, 2021 · 0 comments

Comments

@fjahr
Copy link

fjahr commented Oct 24, 2021

There is a bit of an inconsistency between download and find-bottleneck: download will create the output dir if it doesn't exist, so the command in the readme will succeed even im the dump dir does not exist. On the other hand the find-bottleneck example will fail if the bottleneck dir doesn't exist and it will do so at the very end.

Ideally both commands would work consistently, as a quick fix we could also change the readme or do a check at the beginning of find-bottleneck to make sure that it fails early at least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant