Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually look into corrupted file #27

Open
naumenkogs opened this issue May 18, 2020 · 0 comments
Open

Actually look into corrupted file #27

naumenkogs opened this issue May 18, 2020 · 0 comments

Comments

@naumenkogs
Copy link
Contributor

I looked at the code for a bit #26
It seems like the issue was caused by a corruption in a file.

I'm not sure in which state the buffer appears after we advance past the problematic field.
But I think it doesn't necessary happen at the end of the file, and can happen in the middle.

There are 2 potentially bad outcomes:

  1. we misinterpret the rest of the file, and then make wrong decisions when finding bottleneck (very bad)
  2. we ignore rest of the file (bad but alright I guess)

I'm not sure it's actually easy to recover after the problem. @i7i can you take a look at bytes?

If it's not possible to reliably recover to a good state after passing one bad record, I think we should skip an entire file so that (1) doesn't happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant